[wasm-ep] Remove old sample and JS-based diagnostics #73586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the websocket diagnostic server support instead
use the browser-threading sample for working with threading use the browser-eventpipe sample for working with tracing
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWe initially added support for creating sessions from JS to validate that EP was functional before we had the WebSocket-based diagnostic server. Now we don't need that stuff anymore. Also remove the
|
pavelsavara
approved these changes
Aug 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially added support for creating sessions from JS to validate that EP was functional before we had the WebSocket-based diagnostic server. Now we don't need that stuff anymore.
Also remove the
browser-mt-eventpipesample. Thebrowser-threadingandbrowser-eventpipesamples are the replacements - they do one thing at a time instead of collecting all the experimental cruft