Use buffer.Length as the source of truth for ReadDirectoryChanges' nBufferLength #73970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io Issue Detailsnull
|
stephentoub
reviewed
Aug 15, 2022
src/libraries/System.IO.FileSystem.Watcher/src/System/IO/FileSystemWatcher.Win32.cs
Show resolved
Hide resolved
carlossanlop
approved these changes
Aug 15, 2022
danmoseley
approved these changes
Aug 15, 2022
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
LGTM. I suppose in theory this could have a test that attempts to force the race, but if we were writing this code fresh, I don't think we'd write such a test, and the fix is self evidently how we should have written it.
Member
|
failures so far are the prevalent issue right now... "failed to upload results" |
Member
Author
|
/backport to release/7.0-rc1 |
Contributor
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2870660998 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.