Skip to content

Conversation

@kg
Copy link
Member

@kg kg commented Aug 18, 2022

No description provided.

@kg kg added the arch-wasm WebAssembly architecture label Aug 18, 2022
@kg kg requested review from lewing and pavelsavara as code owners August 18, 2022 18:35
@ghost ghost assigned kg Aug 18, 2022
@kg kg requested a review from lambdageek August 18, 2022 18:35
@ghost
Copy link

ghost commented Aug 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: kg
Assignees: -
Labels:

arch-wasm

Milestone: -

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think FEATURE_WASM_THREADS is defined for non-CoreLib libraries by default - it's something we added by hand to the .csproj

also in .ts we can add some constant folding to encourage rollup to drop all the conditionals

@lewing lewing added this to the 7.0.0 milestone Aug 19, 2022
@lambdageek
Copy link
Member

/azp backport to release/7.0-rc1

@azure-pipelines
Copy link

Command 'backport' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@maraf
Copy link
Member

maraf commented Aug 19, 2022

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2889118587

@kg
Copy link
Member Author

kg commented Aug 19, 2022

Verified that the threads sample works correctly now with @lambdageek's msbuild fix (thanks!)

@kg kg merged commit 801ca3d into dotnet:main Aug 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants