-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Omit the JS sync context if threads are not enabled #74167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
lambdageek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think FEATURE_WASM_THREADS is defined for non-CoreLib libraries by default - it's something we added by hand to the .csproj
also in .ts we can add some constant folding to encourage rollup to drop all the conditionals
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Show resolved
Hide resolved
|
/azp backport to release/7.0-rc1 |
|
Command 'backport' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/backport to release/7.0-rc1 |
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2889118587 |
|
Verified that the threads sample works correctly now with @lambdageek's msbuild fix (thanks!) |
No description provided.