Discourage using explicit package references to ILCompiler to publish… #74769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dotnet#74591) * Show a warning when an explicit package reference to ILCompiler is added * Apply suggestions from code review Co-authored-by: Jan Kotas <[email protected]> * Fix issue 27239 * Apply suggestions from code review Co-authored-by: Sven Boemer <[email protected]> * exclude the warning for direct targets file invoke cases Co-authored-by: Jan Kotas <[email protected]> Co-authored-by: Sven Boemer <[email protected]>
ghost
added
the
sbomer
approved these changes
Aug 29, 2022
jeffschwMSFT
approved these changes
Aug 29, 2022
|
@LakshanF do any of the CI failures look related to your change? |
|
@carlossanlop, I don't think they are related. I thought the earlier failures were related to dotnet/arcade#10631 and re-ran but more started to fail. |
|
Approved, signed off, and CI is green now. Ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#74591)
Publishing a NativeAOT application is supported via the SDK and the 'old' unsupported way that we started via adding explicit package reference is discouraged. The explicit support is for very narrow scenarios like getting the latest fix on native AOT issues before the SDK exposes the fix via its official ILCompiler packages.
We also no longer support publishing an AOT application if the SDK property, PublishAOT, is not set and only the explicit package reference exists. We allowed this behavior (no PublishAOT specified) early in 7.0 when SDK support was not enabled but do not want to continue to support the old way now. SDK path is the only we way want to support except for the narrow scenario described above where PublishAOT is still required for that scenario to work.
Apply suggestions from code review
Co-authored-by: Jan Kotas [email protected]
Fix issue 27239
Apply suggestions from code review
Co-authored-by: Sven Boemer [email protected]
Co-authored-by: Jan Kotas [email protected]
Co-authored-by: Sven Boemer [email protected]