Skip to content

Conversation

@ViktorHofer
Copy link
Member

System.ValueTuple's assembly version had to be pinned when it was consumable by .NET Framework which isn't true anymore. The library now only ships as part of the .NETCoreApp shared framework.

System.ValueTuple's assembly version had to be pinned when it was consumable by .NET Framework which isn't true anymore. The library now only ships as part of the .NETCoreApp shared framework.
@ghost
Copy link

ghost commented Aug 30, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

System.ValueTuple's assembly version had to be pinned when it was consumable by .NET Framework which isn't true anymore. The library now only ships as part of the .NETCoreApp shared framework.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions for my own learning, @ViktorHofer :

  • I am assuming that "pinned" means "fixed in a specific assembly version". If not, can you please explain?
  • What made it possible to remove it this time?
  • What does rev'ed mean? (it was in the comment you removed in the src).
  • What is a partial facade? And why did you remove that line?

cc @smasher164

@ViktorHofer
Copy link
Member Author

I am assuming that "pinned" means "fixed in a specific assembly version". If not, can you please explain?

Yes.

What made it possible to remove it this time?

Mentioned that briefly in the commit / PR description. In the past, this library shipped via a package and also targeted .NET Framework (either as a .NET Framework or .NET Standard assembly). This isn't the case anymore and pinning the assembly version doesn't serve any benefit. To your question, this change could have been made anytime between when the package was removed and now (i.e. .NET 5, .NET 6, .NET 7 and presumably even sooner).

What does rev'ed mean? (it was in the comment you removed in the src).

Rev'ed usually means that a version is incremented. In this case the comment is referring to the assembly version.

What is a partial facade? And why did you remove that line?

A partial facade is a GenFacades specific term and refers to an assembly that type forwards some or all of the API exposed in the contract/ref assembly to an internal implementation assembly, usually System.Private.CoreLib. This change doesn't remove the property, it just moves it after the TargetFramework property.

@ViktorHofer ViktorHofer merged commit 07072a1 into main Aug 30, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch August 30, 2022 20:49
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants