[release/7.0] Fix buffer overruns in GC code #74974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #74847 to release/7.0 /cc @AntonLapounov Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jeffschwMSFT
reviewed
Sep 2, 2022
mangod9
approved these changes
Sep 2, 2022
|
Approved, signed off, CI is green. Ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74847 to release/7.0
/cc @AntonLapounov
Customer Impact
NativeAot-compiled apps that use server GC would intermittently corrupt memory and crash on 80 core Ampere machines running Windows 11/Windows Server 2022. In particular, that affects our NativeAot-compiled crossgen2 compiler under the default execution environment.
Non-NativeAot compiled apps that use server GC would corrupt memory by using an uninitialized stack variable as an index in the native array. That would happen only under non-default execution environment, e.g., when setting
DOTNET_PROCESSOR_COUNT=100andDOTNET_GCNoAffinitize=1.Risk
Low. This change just adds minor validation to GC initialization code.