Remove duplicate SourceGeneration generator refs #75083
Conversation
Unblocks #75058 The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsUnblocks #75058 The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
|
|
Failures are Linux arm64 process terminations, unrelated. |
|
Thanks @ViktorHofer. It looks like there may be another duplicate reference to Could we port this change to |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3001098463 |
|
I've started a backport to |
ghost
locked as resolved and limited conversation to collaborators
Unblocks #75058
The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
Long term for inbox projects, we should agree on either explicitly referencing analyzers (what is currently being done for the JSImportGenerator) or automatically referencing them based on other inputs (currently, LibraryImportGenerator). Mixing both modes caused this issue but also makes it hard to reason about which analyzers run.