Skip to content

Try re-enabling System.Transactions.Local tests on Arm64 #75610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

Try re-enabling System.Transactions.Local tests on Arm64 #75610

merged 1 commit into from
Sep 15, 2022

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Sep 14, 2022

No description provided.

@ghost ghost assigned jkotas Sep 14, 2022
@jkotas jkotas added the NO-REVIEW Experimental/testing PR, do NOT review it label Sep 14, 2022
@jkotas
Copy link
Member Author

jkotas commented Sep 14, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 14, 2022

Azure Pipelines successfully started running 1 pipeline(s).

kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Sep 15, 2022
@kunalspathak
Try re-enabling System.Transactions.Local tests on Arm64 dotnet#75610
d9cd0a3
@jkotas jkotas removed the NO-REVIEW Experimental/testing PR, do NOT review it label Sep 15, 2022
@jkotas jkotas requested a review from roji September 15, 2022 17:53
@jkotas jkotas marked this pull request as ready for review September 15, 2022 17:54
roji
roji approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are we saying we're no longer able to repro any failure, including with jitstress? The would likely mean that the GUID interop fixes (#74226, #74570) made this go away (though IIRC @kunalspathak was able to see the bug with them,
#74226 (comment)).

In any case, we can certainly see if the failures reappear in CI other elsewhere.

@roji
Copy link
Member

roji commented Sep 15, 2022

/cc @ajcvickers

@jkotas
Copy link
Member Author

jkotas commented Sep 15, 2022

None of the failures are related to System.Transactions

@jkotas jkotas merged commit b1f5e97 into dotnet:main Sep 15, 2022
@jkotas jkotas deleted the transations-arm64 branch September 15, 2022 18:16
@jkotas
Copy link
Member Author

jkotas commented Sep 15, 2022

/backport to release/7.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3062739478

@roji
Copy link
Member

roji commented Sep 15, 2022

@jkotas I know, but they were intermittent before as well.

@github-actions github-actions bot mentioned this pull request Sep 15, 2022
Merged
@jkotas
Copy link
Member Author

jkotas commented Sep 15, 2022

@jkotas I know, but they were intermittent before as well.

The System.Transactions tests were run on Win Arm64 multiple times in the CI, and also locally. No crashes observed.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roji roji roji approved these changes

Assignees

@jkotas jkotas

Labels

area-System.Transactions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkotas @roji