[wasm][debugger] Fix behavior of JMC #75783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsWe only should hide private members from types that are not UserCode when JMC is enabled. Fixes #75763
|
radical
reviewed
Sep 17, 2022
radical
reviewed
Sep 17, 2022
| typeName, | ||
| getPropertiesParamBuffer, | ||
| getCommandType.HasFlag(GetObjectCommandOptions.ForDebuggerProxyAttribute), | ||
| getCommandType, |
There was a problem hiding this comment.
You can add GetObjectCommandOptions.AutoExpandable when passing this.
|
This applies to static members too, correct? Can we adjust any tests for that? |
|
Would this work for derived classes shadowing private members in base classes? |
radical
approved these changes
Sep 17, 2022
|
/backport to release/7.0-rc2 |
|
Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3082598820 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only should hide private members from types that are not UserCode when JMC is enabled.
I understood it wrongly when I implemented, fixing it now.
Fixes #75763