Skip to content

JIT: Use gtCloneExpr in fgMorphModToSubMulDiv for potentially complex trees #76061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2022
Merged

JIT: Use gtCloneExpr in fgMorphModToSubMulDiv for potentially complex trees #76061

merged 3 commits into from
Sep 23, 2022

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Sep 23, 2022

We may get here for any invariant dividend/divisor but these can be
'complex' address-of trees that gtClone does not handle.

Fix #76051

@jakobbotsch
Add a test
4b54608
@jakobbotsch
JIT: Use gtCloneExpr in fgMorphModToSubMulDiv for potentially complex…
a27c9cd 
… trees

We may get here for any invariant dividend/divisor but these can be
'complex' address-of trees that gtClone does not handle.

Fix dotnet#76051
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 23, 2022
@ghost ghost assigned jakobbotsch Sep 23, 2022
@ghost
Copy link

ghost commented Sep 23, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

We may get here for any invariant dividend/divisor but these can be
'complex' address-of trees that gtClone does not handle.

Fix #76051

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Sep 23, 2022

Maybe we can rename gtClone globally? to something that reflects that it might return nullptr for complex trees, e.g.
gtCloneIfSimple
gtTryClone
gtCloneSimpleTree
etc

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Sep 23, 2022

Maybe we can rename gtClone globally? to something that reflects that it might return nullptr for complex trees, e.g.
gtCloneIfSimple
gtTryClone
gtCloneSimpleTree
etc

Seems like a good idea, but as a separate change since we should probably backport this one.

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Sep 23, 2022

Failures look like #76041 and #76070

@jakobbotsch jakobbotsch merged commit 1a9f573 into dotnet:main Sep 23, 2022
@jakobbotsch jakobbotsch deleted the fix-76051 branch September 23, 2022 16:40
@tannergooding tannergooding mentioned this pull request Sep 23, 2022
Merged
@neon-sunset
Copy link
Contributor

neon-sunset commented Sep 23, 2022

Will this change be backported to 7.0?

@AndyAyersMS
Copy link
Member

AndyAyersMS commented Sep 23, 2022

Will this change be backported to 7.0?

I expect so, yes.

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Sep 26, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3126305425

@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Project segfaults on Ubuntu ( ARM64 )

4 participants

@jakobbotsch @EgorBo @neon-sunset @AndyAyersMS