Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Oct 4, 2022

This was hitting a compiler crash due to System.Reflection.Metadata bug around generic attributes. Since we now host the compiler with .NET 7 RC1 bits, the problem is gone.

Cc @dotnet/ilc-contrib

This was hitting a compiler crash due to System.Reflection.Metadata bug around generic attributes. Since we now host the compiler with RC1 bits, the problem should be gone.

No merge for now because this should not be promoted to a smoke test, just unblocked in the extra-platforms run.
@MichalStrehovsky MichalStrehovsky added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-NativeAOT-coreclr labels Oct 4, 2022
@ghost ghost assigned MichalStrehovsky Oct 4, 2022
@MichalStrehovsky MichalStrehovsky changed the title Check if S.R.Metadata tests now pass Start running S.R.Metadata tests Oct 4, 2022
@MichalStrehovsky MichalStrehovsky removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 4, 2022
@MichalStrehovsky MichalStrehovsky changed the title Start running S.R.Metadata tests [NativeAot] Start running S.R.Metadata tests Oct 4, 2022
@jkotas
Copy link
Member

jkotas commented Oct 4, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas merged commit 8fd74f3 into main Oct 4, 2022
@jkotas jkotas deleted the MichalStrehovsky-patch-1 branch October 4, 2022 22:23
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants