Skip to content

[wasm] interp perf to dev tools #77171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[wasm] interp perf to dev tools #77171

wants to merge 6 commits into from

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Oct 18, 2022

interp reporting directly to chrome dev tools via performance.measure()

Contributes to #76316

@pavelsavara pavelsavara added this to the 8.0.0 milestone Oct 18, 2022
@pavelsavara pavelsavara self-assigned this Oct 18, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

interp reporting directly to chrome dev tools via performance.measure()

Contributes to #76316

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

pavelsavara commented Oct 18, 2022

image

vargaz
vargaz reviewed Oct 19, 2022
View reviewed changes
@pavelsavara
Copy link
Member Author

pavelsavara commented Oct 19, 2022

I just understood that src\mono\mono\profiler\aot.c is just plugin into src\mono\mono\metadata\profiler-private.h and it also works in wasm.

So I could use the same technique to do the browser integration.

mono_profiler_get_call_instrumentation_flags is what drives this

@runfoapp runfoapp bot mentioned this pull request Oct 19, 2022
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Oct 26, 2022

Closed in favor of #77449

@ghost ghost locked as resolved and limited conversation to collaborators Nov 25, 2022
@pavelsavara pavelsavara deleted the wasm_perf_measure branch September 2, 2024 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad will be requested when the pull request is marked ready for review BrzVlad is a code owner

@kotlarmilos kotlarmilos Awaiting requested review from kotlarmilos kotlarmilos will be requested when the pull request is marked ready for review kotlarmilos is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@vargaz vargaz vargaz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @vargaz