Skip to content

[wasm] optimize interop startup and linker hints #77256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

[wasm] optimize interop startup and linker hints #77256

merged 1 commit into from
Dec 9, 2022

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Oct 20, 2022 •
edited
Loading

Prepare for making legacy interop optional

  • move methods used only in legacy into LegacyHostImplementation class
  • rename GetTaskResult to GetTaskResultDynamic
  • make s_taskGetResultMethodInfo initialization lazy
  • rationalize DynamicDependency

@pavelsavara pavelsavara added this to the 8.0.0 milestone Oct 20, 2022
@ghost ghost assigned pavelsavara Oct 20, 2022
@ghost
Copy link

ghost commented Oct 20, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

new FF AppStart, Reach managed: 355.1764705882353ms
new chrome AppStart, Reach managed: 249.43478260869566ms
old FF AppStart, Reach managed: 359.3529411764706ms
old chrome AppStart, Reach managed: 256.6ms

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara force-pushed the wasm_optimize_interop_startup branch from 542f89f to 9c2317b Compare October 27, 2022 11:35
@pavelsavara pavelsavara changed the title [wasm] optimize interop startup [wasm] optimize interop startup and linker hints Oct 27, 2022
@pavelsavara pavelsavara force-pushed the wasm_optimize_interop_startup branch from 9c2317b to 38fc995 Compare October 27, 2022 13:15
@build-analysis build-analysis bot mentioned this pull request Oct 27, 2022
Closed
@ghost ghost closed this Nov 26, 2022
@ghost
Copy link

ghost commented Nov 26, 2022

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@pavelsavara pavelsavara reopened this Nov 28, 2022
This was referenced Nov 28, 2022
Closed
Closed
@pavelsavara pavelsavara force-pushed the wasm_optimize_interop_startup branch from 38fc995 to 0e4f591 Compare December 8, 2022 14:34
@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 8, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara requested a review from kg December 8, 2022 14:35
@pavelsavara pavelsavara marked this pull request as ready for review December 8, 2022 18:12
@pavelsavara pavelsavara requested a review from lewing as a code owner December 8, 2022 18:12
@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 9, 2022

CI failure is #70985

@pavelsavara pavelsavara merged commit add75d0 into dotnet:main Dec 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2023
@pavelsavara pavelsavara deleted the wasm_optimize_interop_startup branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@kg kg Awaiting requested review from kg

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @maraf