Skip to content

[wasm] Add IMemoryView as exported type #77371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2022
Merged

[wasm] Add IMemoryView as exported type #77371

merged 2 commits into from
Oct 24, 2022

Conversation

@maraf
Copy link
Member

@maraf maraf commented Oct 24, 2022

Based on discussion in the dotnet/AspNetCore.Docs#27311 (comment)

@maraf maraf added this to the 8.0.0 milestone Oct 24, 2022
@maraf maraf self-assigned this Oct 24, 2022
@ghost
Copy link

ghost commented Oct 24, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on discussion in the dotnet/AspNetCore.Docs#27311 (comment)

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@maraf
Copy link
Member Author

maraf commented Oct 24, 2022

@pavelsavara Should I make IMemoryView extend IDispoable? Currently on the implementation Span and ArraySegment does implement it, but since these types are not exported, user won't probably know about disposing.

@pavelsavara
Copy link
Member

pavelsavara commented Oct 24, 2022 •
edited
Loading

@pavelsavara Should I make IMemoryView extend IDispoable?

Yes please!

pavelsavara
pavelsavara approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@maraf maraf merged commit 41db775 into dotnet:main Oct 24, 2022
@maraf maraf deleted the WasmMemoryViewExport branch October 24, 2022 19:13
@maraf
Copy link
Member Author

maraf commented Oct 24, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3315477203

@github-actions github-actions bot mentioned this pull request Oct 24, 2022
Merged
@maraf maraf mentioned this pull request Oct 25, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf @pavelsavara