[Mono] Disable SIMD intrinsics for Vector128/64 on Arm64 #77406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
vargaz
approved these changes
Oct 24, 2022
|
@fanyang-mono @jonathanpeppers - I believe this should be backported for 7.0 servicing ? |
|
Yes, it would be great to get this in 7.0, thanks. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3323392656 |
|
@fanyang-mono an error occurred while backporting to release/7.0, please check the run log for details! Error: @fanyang-mono is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=fanyang-mono |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3323392656 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After disabling Arm intrinsics, the android team hit another issue with Vector128 when enabling LLVM. It was also a mixed mode issue. This PR disables Vector128/64 intrinsics.
Fixes #77319