Skip to content

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Nov 10, 2022

I removed the code and it works well debugging from VS and also from Chrome, also the debugger-tests works well without this code.

Fixes #76777

@thaystg thaystg requested a review from lewing November 10, 2022 16:50
@thaystg thaystg requested a review from radical as a code owner November 10, 2022 16:50
@ghost ghost added the area-Debugger-mono label Nov 10, 2022
@ghost ghost assigned thaystg Nov 10, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

I removed the code and it works well debugging from VS and also from Chrome, also the debugger-tests works well without this code.

Fixes #76777

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg changed the title [wasm][debugger] Don't need to escape non-ascii characters anymore [wasm][debugger] Don't need to escape special characters anymore Nov 10, 2022
@marek-safar
Copy link
Contributor

I think we want to backport this to 7.x

@thaystg
Copy link
Member Author

thaystg commented Nov 11, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3444998494

@github-actions
Copy link
Contributor

@thaystg backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: remove unnecessary code
Using index info to reconstruct a base tree...
M	src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
CONFLICT (content): Merge conflict in src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 remove unnecessary code
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@thaystg an error occurred while backporting to release/7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@thaystg thaystg merged commit ce0b82e into dotnet:main Nov 11, 2022
@radical
Copy link
Member

radical commented Nov 14, 2022

@thaystg @ilonatommy Was this reproducible only with Blazor? Was this reproducible without VS?

@ilonatommy
Copy link
Member

ilonatommy commented Nov 14, 2022

State before the fix.
Special signs in path (#):

  • wasmbrowser on Browser: OK
  • wasmbrowser on VS: OK
  • blazorwasm on Browser: OK
  • blazorwasm on VS: OK

Diacritic signs in path (żółw):

  • wasmbrowser on Browser: NOT OK (a mess in finding files)
  • wasmbrowser on VS: OK
  • blazorwasm on Browser: NOT OK (files names are found but loaded without content and under a wrong tree)
  • blazorwasm on VS: NOT OK

EDIT:
my bad, now when I checked more systematically, it turns out that this introduces a regression.

After fix:
Special signs in path (#):

  • wasmbrowser on Browser: OK
  • wasmbrowser on VS: OK
  • blazorwasm on Browser: NOT OK [regression]
  • blazorwasm on VS: NOT OK [regression]

Diacritic signs in path (żółw):

  • wasmbrowser on Browser: NOT OK
  • wasmbrowser on VS: OK
  • blazorwasm on Browser: OK [improvement]
  • blazorwasm on VS: OK [improvement]

@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot hit breakpoint when Blazor wasm project path contains special characters

4 participants