Ensure ReadBufferState resets any BOM offsets every time the buffer is advanced. #78221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFixes a reported regression from .NET 6 where the STJ async reader will skip a number of bytes from the source stream in certain cases where a BOM is included.
|
eiriktsarpalis
force-pushed
the
fix-bom-handling
branch
from
f326a54 to
45def37
Compare
eiriktsarpalis
added
tenet-reliability
eiriktsarpalis
commented
Nov 11, 2022
...tem.Text.Json/tests/System.Text.Json.Tests/Serialization/JsonSerializerWrapper.Reflection.cs
Outdated
Show resolved
Hide resolved
…rialization/JsonSerializerWrapper.Reflection.cs
steveharter
reviewed
Nov 11, 2022
...tem.Text.Json/tests/System.Text.Json.Tests/Serialization/JsonSerializerWrapper.Reflection.cs
Show resolved
Hide resolved
steveharter
approved these changes
Nov 11, 2022
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3446988329 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a reported regression from .NET 6 where the STJ async reader will skip a number of bytes from the source stream in certain cases where a BOM is included.
Should be backported to release/7.0