[wasm] Update failure message for helix retry #78655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message in the test report is: ```xml <Message>System.IO.IOException : [testId: 34] Timed out after 20s waiting for the browser to be ready: C:\helix\work\correlation\chrome-win\chrome.exe</Message> ``` Update to use regex, and match the whole message.
radical
added
arch-wasm
|
Tagging subscribers to this area: @thaystg Issue DetailsThe message in the test report is: <Message>System.IO.IOException : [testId: 34] Timed out after 20s waiting for the browser to be ready: C:\helix\work\correlation\chrome-win\chrome.exe</Message>Update to use regex, and match the whole message.
|
ghost
assigned
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThe message in the test report is: <Message>System.IO.IOException : [testId: 34] Timed out after 20s waiting for the browser to be ready: C:\helix\work\correlation\chrome-win\chrome.exe</Message>Update to use regex, and match the whole message.
|
radical
force-pushed
the
chrome-retry
branch
from
834f183 to
218d2f5
Compare
ChadNedzlek
approved these changes
Nov 21, 2022
Member
Author
|
Merging this because the change was tested explicitly. And the normal CI run won't catch trigger anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message in the test report is:
Update to use regex, and match the whole message.
Fixes #76528 .