Link static libstdc++ with libicuc in NativeAOT #79501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-NativeAOT-coreclr
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
$ uname -a
Linux 4405bca6c481 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 Linux
$ dotnet publish -p:PublishAot=true -o dist
$ file dist/gh-79498
dist/gh-79498: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, BuildID[sha1]=8b2876d810f668a4713963382c5d31f635426b6f, with debug_info, not strippedFixes #79498
|
am11
force-pushed
the
feature/nativeaot/static-icu
branch
from
a3ae425 to
9dde554
Compare
am11
force-pushed
the
feature/nativeaot/static-icu
branch
from
9dde554 to
26c7c02
Compare
jkotas
reviewed
Dec 11, 2022
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 11, 2022
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
|
@smhmhmd @Beau-Gosse-dev Does this change look good? |
This was referenced Dec 11, 2022
|
@jkotas Also, progress on full-static builds for Alpine is awesome. |
|
All known failures according to the build analysis |
kant2002
added a commit
to kant2002/NativeAOTDocker
that referenced
this pull request
Dec 26, 2022
dotnet/runtime#79501 is landed, so workaround is not needed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libicucdepends onlibstdc++. Statically linking the ICU requires stdc++ to be linked. Also, to produce 100% static executable-Wl,-Bdynamicis unnecessary.Fixes #79498