Skip to content

[mono][aot] Fixed decompose_flag propagation issues #79849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

[mono][aot] Fixed decompose_flag propagation issues #79849

merged 1 commit into from
Dec 20, 2022

Conversation

@jandupej
Copy link
Contributor

@jandupej jandupej commented Dec 20, 2022

Addresses #79710.

@ghost
Copy link

ghost commented Dec 20, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned jandupej Dec 20, 2022
@jandupej
Copy link
Contributor Author

jandupej commented Dec 20, 2022

Some build failures due to #79843.

@jandupej jandupej merged commit 9fe3afe into dotnet:main Dec 20, 2022
@build-analysis build-analysis bot mentioned this pull request Dec 20, 2022
Closed
@jandupej
Copy link
Contributor Author

jandupej commented Dec 20, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3741930000

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

@jandupej an error occurred while backporting to release/7.0, please check the run log for details!

Error: @jandupej is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=jandupej

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3741930000

@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Merged
@build-analysis build-analysis bot mentioned this pull request Dec 21, 2022
Closed
@lewing
Copy link
Member

lewing commented Jan 6, 2023

should this go back to 6.0 too?

@jandupej
Copy link
Contributor Author

jandupej commented Jan 6, 2023 •
edited
Loading

@lewing #79710 mentions the issue does occur with 6.0.
EDIT: Sorry, the problem is reported only on 7.0. They say 6.0 is fine.

@jandupej jandupej mentioned this pull request Jan 10, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

1 more reviewer

@vargaz vargaz vargaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jandupej jandupej

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jandupej @lewing @vargaz