Skip to content

[mono][interp] Fix issue with clearing of unused defs #80186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[mono][interp] Fix issue with clearing of unused defs #80186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/mono/mono/mini/interp/transform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9057,9 +9057,12 @@ interp_cprop (TransformData *td)
if (num_dregs) {
// Check if the previous definition of this var was used at all.
// If it wasn't we can just clear the instruction
//
// MINT_MOV_DST_OFF doesn't fully write to the var, so we special case it here
if (local_defs [dreg].ins != NULL &&
local_defs [dreg].ref_count == 0 &&
!td->locals [dreg].indirects) {
!td->locals [dreg].indirects &&
opcode != MINT_MOV_DST_OFF) {
InterpInst *prev_def = local_defs [dreg].ins;
if (MINT_NO_SIDE_EFFECTS (prev_def->opcode)) {
for (int i = 0; i < mono_interp_op_sregs [prev_def->opcode]; i++)
Expand Down