Skip to content

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Jan 13, 2023

Backport of #79822 to release/6.0

/cc @thaystg

Customer Impact

When the customer application has a Debugger.Break it was crashing the app when running on release mode.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1675269

Testing

Manually tested.

Risk

Low risk, only calling raise(SIGTRAP) when native debugging option is enabled.

@thaystg thaystg requested a review from marek-safar as a code owner January 13, 2023 14:52
@ghost ghost added the area-Debugger-mono label Jan 13, 2023
@ghost ghost assigned thaystg Jan 13, 2023
@thaystg thaystg requested a review from lambdageek January 13, 2023 14:53
@ghost
Copy link

ghost commented Jan 13, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79822 to release/6.0

/cc @thaystg

Customer Impact

When the customer application has a Debugger.Break it was crashing the app when running on release mode.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1675269

Testing

Manually tested.

Risk

Low risk, only calling raise(SIGTRAP) when native debugging option is enabled.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono

Milestone: -

@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Jan 13, 2023
@lambdageek lambdageek added this to the 6.0.x milestone Jan 13, 2023
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 13, 2023
@carlossanlop carlossanlop modified the milestones: 6.0.x, 6.0.14 Jan 13, 2023
@carlossanlop
Copy link
Contributor

carlossanlop commented Jan 13, 2023

@carlossanlop carlossanlop merged commit dea5221 into dotnet:release/6.0 Jan 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants