Skip to content

System.Console: allow terminfo files to be larger than 4KiB. #82038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2023
Merged

System.Console: allow terminfo files to be larger than 4KiB. #82038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
175cb88
System.Console: allow terminfo files to be larger than 4KiB.
tmds Feb 13, 2023
dee32c3
Remove file size check.
tmds Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libraries/System.Console/src/System/TermInfo.DatabaseFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,8 @@ private static bool TryOpen(string filePath, [NotNullWhen(true)] out SafeFileHan
{
// Read in all of the terminfo data
long termInfoLength = RandomAccess.GetLength(fd);
const int MaxTermInfoLength = 4096; // according to the term and tic man pages, 4096 is the terminfo file size max
const int HeaderLength = 12;
if (termInfoLength <= HeaderLength || termInfoLength > MaxTermInfoLength)
if (termInfoLength <= HeaderLength)
{
throw new InvalidOperationException(SR.IO_TermInfoInvalid);
}
Expand Down