Separate the generation of PerfMap and JitDump files #82142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davmason
suggested changes
Feb 15, 2023
ghost
added
needs-author-action
davmason
approved these changes
Mar 7, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DOTNET_PerfMapEnabled environment variable is turned on, both PerfMap and JitDump files are generated. However, JitDump support was added to the 5.4 Linux kernel and are a superset of functionality over PerfMap. Thus, allowing the user to choose which file type to generate, based on factors such as kernel version and tool support, instead of always generating both would provide a performance improvement. The new values for PerfMapEnabled would be the following:
This provides the original functionality of setting DOTNET_PerfMapEnabled=1 to generate both file types while also allowing the generation of only one file type.