Skip to content

Avx512 single kmask #82255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Avx512 single kmask #82255

wants to merge 12 commits into from

Conversation

@anthonycanino
Copy link
Contributor

@anthonycanino anthonycanino commented Feb 16, 2023

Draft PR for testing. Has a dependency on #80960

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 16, 2023
@ghost
Copy link

ghost commented Feb 16, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Draft PR for testing. Has a dependency on #80960

Author: anthonycanino
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Feb 17, 2023
Closed
kunalspathak
kunalspathak suggested changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

src/coreclr/jit/lsra.h Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just rename this from OpmaskRegister to MaskRegister here and at other places like isMaskReg(), etc.

src/coreclr/jit/vartype.h Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just return TypeGet(v) == TYP_OPMASK;?

src/coreclr/jit/instr.cpp Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why is IsKInstruction() included in this condition?

Copy link
Contributor Author

@anthonycanino anthonycanino Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because k instructions, i.e.g, kmov, kadd, do not get the v prefix.

src/coreclr/jit/hwintrinsiccodegenxarch.cpp Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Also can we add an assert that assert(isOpmaskReg(maskReg))?

Copy link
Contributor Author

@anthonycanino anthonycanino Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I meant maskReg should be an OpmaskReg. I put the assert in and removed the comment.

src/coreclr/jit/emitxarch.cpp Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the comment to reflect about the k-mask instruction.

src/coreclr/jit/emitxarch.cpp Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that I understand, the other 2 instructions i.e. vpmovb2m and vpmovd2m doesn't take Rex prefix?

Copy link
Contributor Author

@anthonycanino anthonycanino Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. vpmovb2m and vpmovd2m have w bit set to 0.

src/coreclr/jit/emitxarch.cpp Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this properly.

src/coreclr/jit/emitxarch.cpp Outdated
Copy link
Contributor

@kunalspathak kunalspathak Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add proper values as part of the PR.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 17, 2023
@build-analysis build-analysis bot mentioned this pull request Feb 17, 2023
Closed
4 tasks
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@kunalspathak kunalspathak kunalspathak requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anthonycanino @kunalspathak @DeepakRajendrakumaran