Skip to content

Conversation

@pavelsavara
Copy link
Member

Fixes #78389 which is API approval

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm labels Mar 1, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Mar 1, 2023
@pavelsavara pavelsavara requested review from lewing and maraf March 1, 2023 08:33
@pavelsavara pavelsavara self-assigned this Mar 1, 2023
@ghost
Copy link

ghost commented Mar 1, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 1, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Mar 1, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #78389 which is API approval

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, os-wasi

Milestone: 8.0.0

@pavelsavara pavelsavara marked this pull request as ready for review March 1, 2023 14:33
@pavelsavara
Copy link
Member Author

CI failures are unrelated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture new-api-needs-documentation os-wasi Related to WASI variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: OperatingSystem.IsWasi()

2 participants