Skip to content

[browser] Calculate hash for runtime assets #82891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 3, 2023
Merged

[browser] Calculate hash for runtime assets #82891

merged 5 commits into from
Mar 3, 2023

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 2, 2023 •
edited
Loading

  • calculate SHA256 hash and use in to check integrity of the download
  • calculate SHA256 of all assets (to be used later for memory snapshot)
  • skip non-IL assemblies and issue message for it. Fixes [browser] don't publish native DLLs #82888

@pavelsavara pavelsavara added this to the 8.0.0 milestone Mar 2, 2023
@pavelsavara pavelsavara self-assigned this Mar 2, 2023
@ghost
Copy link

ghost commented Mar 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • calculate SHA256 hash and use in to check integrity of the download
  • calculate SHA256 of all assets (to be used later for memory snapshot)
  • skip non-IL assemblies and issue warning for it. Fixes [browser] don't publish native DLLs #82888
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

vcsjones
vcsjones reviewed Mar 2, 2023
View reviewed changes
radical
radical reviewed Mar 2, 2023
View reviewed changes
radical
radical reviewed Mar 2, 2023
View reviewed changes
radical
radical reviewed Mar 2, 2023
View reviewed changes
@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 2, 2023

/azp run runtime-wasm

@pavelsavara pavelsavara marked this pull request as ready for review March 2, 2023 18:35
@pavelsavara pavelsavara requested a review from lewing as a code owner March 2, 2023 18:35
@azure-pipelines
Copy link

azure-pipelines bot commented Mar 2, 2023

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Mar 2, 2023
Closed
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 3, 2023

CI failure is #82880

@pavelsavara pavelsavara merged commit de48b5a into dotnet:main Mar 3, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2023
@pavelsavara pavelsavara deleted the browser_hash_assets branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical left review comments

@vcsjones vcsjones vcsjones left review comments

@maraf maraf maraf approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@kg kg Awaiting requested review from kg

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[browser] don't publish native DLLs

5 participants

@pavelsavara @radical @vcsjones @maraf @ilonatommy