[wasm] Add a monitoring phase to jiterpreter traces and discard unproductive ones #83432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
requested review from
BrzVlad,
kotlarmilos,
lambdageek,
lewing,
pavelsavara and
vargaz
as code owners
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis PR adds a monitoring phase to jiterpreter traces, where we measure their result displacement (in bytes) and reject traces that appear to be aborting early (due to things like calls). A proper implementation of this would measure the number of executed opcodes instead, but it's currently not possible to do that. In my testing this significantly improves the performance of V8.Crypto.Bench, one of the remaining significant regressions from the dotnet/performance suite.
|
vargaz
approved these changes
Mar 15, 2023
This was referenced Mar 15, 2023
kg
added a commit
to kg/runtime
that referenced
this pull request
Mar 15, 2023
…rd unproductive ones (dotnet#83432)" This reverts commit 1cfda5e.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a monitoring phase to jiterpreter traces, where we measure their result displacement (in bytes) and reject traces that appear to be aborting early (due to things like calls). A proper implementation of this would measure the number of executed opcodes instead, but it's currently not possible to do that.
In my testing this significantly improves the performance of V8.Crypto.Bench, one of the remaining significant regressions from the dotnet/performance suite.