[wasm][debugger] Retry after timeout on debugger tests on CI #84080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

thaystg merged 17 commits into dotnet:main from thaystg:test_fix_83847

Apr 5, 2023

Member

thaystg commented Mar 29, 2023

Adding --disable-software-rasterizer as suggested by @lewing


          Adding --disable-software-rasterizer as suggested by @lewing

4f17dc7

ghost assigned thaystg

ghost added the area-Debugger-mono label

ghost commented Mar 29, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Adding --disable-software-rasterizer as suggested by @lewing

Author:	thaystg
Assignees:	thaystg
Labels:	`area-Debugger-mono`
Milestone:	-

Member Author

thaystg commented Mar 29, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Mar 29, 2023

Azure Pipelines successfully started running 1 pipeline(s).

thaystg changed the title ~~[wasm][debugger] Adding --disable-software-rasterizer option~~ [wasm][debugger] Passing --disable-software-rasterizer argument to Chrome Startup

build-analysis bot mentioned this pull request

Wasm debugger test timing out #83847

Closed


          Trying to add --no-sandbox also when CI is detected

c00bac2

thaystg changed the title ~~[wasm][debugger] Passing --disable-software-rasterizer argument to Chrome Startup~~ [wasm][debugger] Passing --no-sandbox argument to Chrome Startup on CI

Member Author

thaystg commented Mar 29, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Mar 29, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          TRying to automatically retry if a test timeout.

a37daf6

thaystg changed the title ~~[wasm][debugger] Passing --no-sandbox argument to Chrome Startup on CI~~ [wasm][debugger] Debugging debugger tests on CI

thaystg changed the title ~~[wasm][debugger] Debugging debugger tests on CI~~ [wasm][debugger] Investigating timeout on debugger tests on CI

thaystg added 5 commits

March 30, 2023 00:03


          fix compilation error

fac595a


          Try another fix


          Fix compilation

76670c1


          retrying if timeout OpenSessionAsync.

bdcd4d3


          Adding more log

9562f31

azure-pipelines bot commented Mar 30, 2023

No pipelines are associated with this pull request.

Member Author

thaystg commented Mar 30, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Mar 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

thaystg commented Mar 30, 2023

/azp run runtime

azure-pipelines bot commented Mar 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Fix retry

c6a0cbf

Member Author

thaystg commented Mar 30, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Mar 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).

thaystg added 2 commits

March 30, 2023 19:38


          Fix compilation

306d87f


          Create another id for the retry

f2e9abb

Member Author

thaystg commented Apr 3, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Remove unrelated change

d691494

Member Author

thaystg commented Apr 3, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

thaystg commented Apr 3, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

thaystg commented Apr 3, 2023

/azp run runtime-wasm-dbgtests

Member Author

thaystg commented Apr 3, 2023

/azp run runtime

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

thaystg commented Apr 3, 2023

/azp run runtime

Member Author

thaystg commented Apr 3, 2023

/azp run runtime-wasm-dbgtests

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Apr 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

thaystg commented Apr 4, 2023

/azp run runtime-wasm-dbgtests

Member Author

thaystg commented Apr 4, 2023

/azp run runtime

azure-pipelines bot commented Apr 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Apr 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).

thaystg marked this pull request as ready for review

April 4, 2023 18:48

thaystg requested a review from radical as a code owner

April 4, 2023 18:48

thaystg changed the title ~~[wasm][debugger] Investigating timeout on debugger tests on CI~~ [wasm][debugger] Retry after timeout on debugger tests on CI

thaystg requested a review from lewing

April 4, 2023 19:21

lewing reviewed

View reviewed changes

src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs Show resolved Hide resolved


          Update src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs

4a623f4

Co-authored-by: Larry Ewing <[email protected]>

lewing approved these changes

View reviewed changes

src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs

    
                                  if (!res.IsOk)

                                      throw new ArgumentException($"Command {cmd_name} failed with: {res.Error}. Remaining commands: {RemainingCommandsToString(cmd_name, init_cmds)}");

                                  if (DebuggerTestBase.RunningOnChrome && cmd_name == "Debugger.enable")

Member

lewing Apr 5, 2023

It feels a little odd to pass an empty string just to ignore it unless it is chrome and is there ever a case where we'd try to navigate to "" on chrome?

Member Author

thaystg Apr 5, 2023

I'm not sure if I understood the question.
Before this change we startup the chrome passing the url that it should navigate. And on my tests I saw that sometimes it was timing out the debugger.enable command. So I decided to first startup the chrome navigating to about:blank then send the Debugger.enabled and then when we receive the answer we send the Page.navigate to the wasm page.
On firefox we don't need to navigate to the page because we are still starting the browser passing the wasm page as parameter.

Member Author

thaystg commented Apr 5, 2023

I will merge, the failure is not related to timeout.

thaystg merged commit 5130ba9 into dotnet:main

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-mono