Skip to content

Conversation

@ViktorHofer
Copy link
Member

See discussion in dotnet/source-build-reference-packages#633 for more context.

The middle / long term goal is to not depend on the SBRP package but meanwhile, we upgrade the TFM used from netcoreapp2.1 to net6.0.

@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

See discussion in dotnet/source-build-reference-packages#633 for more context.

The middle / long term goal is to not depend on the SBRP package but meanwhile, we upgrade the TFM used from netcoreapp2.1 to net6.0.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member Author

@MichaelSimons I guess we need to merge the SBRP PR first as otherwise runtime's runtime-dev-innerloop (Build linux-x64 Release PortableSourceBuild) leg would start failing?

@MichaelSimons
Copy link
Member

Thoughts on doing the SBRP changes in two steps.

  1. Modify your PR to generate SqlClient to include net6.0 and netcoreapp2.1.
  2. When I remove netcoreapp2.1 from SBRP I will remove is from SqlClient.

The advantage of this approach is it will not block any of the dependency flows.

@ViktorHofer
Copy link
Member Author

Thoughts on doing the SBRP changes in two steps.

Sounds good. I just updated dotnet/source-build-reference-packages#633.

@ViktorHofer ViktorHofer reopened this Apr 14, 2023
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 17, 2023

@MichaelSimons do you know what needs to be done to have access to the new SBRP System.Data.SqlClient package? We already merged the PR in end of last week. Do SBRP packages need to flow into a source build feed that is used in this leg?

@MichaelSimons
Copy link
Member

@MichaelSimons do you know what needs to be done to have access to the new SBRP System.Data.SqlClient package? We already merged the PR in end of last week. Do SBRP packages need to flow into a source build feed that is used in this leg?

Nothing special is needed other than to upgrade to an appropriate version of SBRP. Looking at the build history, your changes went into SBRP 8.0.0-alpha.1.23214.3.

@MichaelSimons
Copy link
Member

runtime doesn't have an SBRP dependency in main yet. @oleksandr-didyk is adding it with his prebuilt detection changes.

@ViktorHofer
Copy link
Member Author

Without such a dependency, which SBRP is used then?

@MichaelSimons
Copy link
Member

Without such a dependency, which SBRP is used then?

The source-build runtime leg is not using SBRP at all them.

@carlossanlop carlossanlop added the blocked Issue/PR is blocked on something - see comments label May 3, 2023
@MichaelSimons
Copy link
Member

MichaelSimons commented May 19, 2023

@ViktorHofer - You should merge in main now that the prebuilt detection PR has been merged. I don't think any other changes are necessary.

@ViktorHofer ViktorHofer removed the blocked Issue/PR is blocked on something - see comments label May 19, 2023
@ViktorHofer ViktorHofer reopened this May 19, 2023
@ViktorHofer ViktorHofer merged commit e108a1a into main May 19, 2023
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch May 19, 2023 15:56
@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants