-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Use net6.0 SqlClient TFM under source-build #84782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See discussion in dotnet/source-build-reference-packages#633 for more context.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsSee discussion in dotnet/source-build-reference-packages#633 for more context. The middle / long term goal is to not depend on the SBRP package but meanwhile, we upgrade the TFM used from netcoreapp2.1 to net6.0.
|
|
@MichaelSimons I guess we need to merge the SBRP PR first as otherwise runtime's |
|
Thoughts on doing the SBRP changes in two steps.
The advantage of this approach is it will not block any of the dependency flows. |
Sounds good. I just updated dotnet/source-build-reference-packages#633. |
|
@MichaelSimons do you know what needs to be done to have access to the new SBRP System.Data.SqlClient package? We already merged the PR in end of last week. Do SBRP packages need to flow into a source build feed that is used in this leg? |
Nothing special is needed other than to upgrade to an appropriate version of SBRP. Looking at the build history, your changes went into SBRP 8.0.0-alpha.1.23214.3. |
|
runtime doesn't have an SBRP dependency in main yet. @oleksandr-didyk is adding it with his prebuilt detection changes. |
|
Without such a dependency, which SBRP is used then? |
The source-build runtime leg is not using SBRP at all them. |
|
@ViktorHofer - You should merge in main now that the prebuilt detection PR has been merged. I don't think any other changes are necessary. |
See discussion in dotnet/source-build-reference-packages#633 for more context.
The middle / long term goal is to not depend on the SBRP package but meanwhile, we upgrade the TFM used from netcoreapp2.1 to net6.0.