Skip to content

Address a couple TODO-ADDRs #84906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2023
Merged

Address a couple TODO-ADDRs #84906

merged 3 commits into from
Apr 19, 2023

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 16, 2023 •
edited
Loading

Just the simple items.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 16, 2023
@ghost
Copy link

ghost commented Apr 16, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Just the simple items.

Couple regressions are expected from the FIELD/GTF_EXCEPT changes (we weren't setting it for some spans).

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review April 18, 2023 20:44
@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Apr 18, 2023 •
edited
Loading

Diffs.

One regression that will be fixed by #84868.

@dotnet/jit-contrib

SingleAccretion
SingleAccretion commented Apr 18, 2023
View reviewed changes
src/coreclr/jit/simdcodegenxarch.cpp
Comment on lines +50 to +55
if (addr->isContained() && addr->OperIs(GT_LCL_ADDR))
{
genEmitStoreLclTypeSimd12(treeNode, addr->AsLclFld()->GetLclNum(), addr->AsLclFld()->GetLclOffs());
genUpdateLife(treeNode);
return;
}
Copy link
Contributor Author

@SingleAccretion SingleAccretion Apr 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative fix to this would have been to simply disallow containment of local addresses for SIMD12s.

This would work because accurate liveness tracking for SIMD12s is neither used nor important, but it felt more consistent with the rest of codegen to handle it. Perhaps, one day, we'll delete this code.

Copy link
Member

@jakobbotsch jakobbotsch Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite confusing that emitHandleMemOp does not support contained LCL_ADDR nodes when Lowering::ContainCheckIndir does. I wonder if we have more bugs around this.

tannergooding
tannergooding reviewed Apr 18, 2023
View reviewed changes
@jakobbotsch jakobbotsch merged commit 2cfef64 into dotnet:main Apr 19, 2023
@SingleAccretion SingleAccretion deleted the Small-TODO-ADDR branch April 19, 2023 20:24
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion @jakobbotsch @tannergooding