Skip to content

[mono][aot] Skip methods only in DEDUP_SKIP phase #85044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[mono][aot] Skip methods only in DEDUP_SKIP phase #85044

wants to merge 1 commit into from

Conversation

@kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Apr 19, 2023 •
edited
Loading

This PR should fix dotnet/perf-autofiling-issues#16477. It reverts the the change that skip collected methods in DEDUP_COLLECT phase.

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Apr 19, 2023
@kotlarmilos kotlarmilos self-assigned this Apr 19, 2023
@lambdageek lambdageek mentioned this pull request Apr 19, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Apr 19, 2023
Closed
@kotlarmilos
Copy link
Member Author

kotlarmilos commented Apr 19, 2023

During the DEDUP_COLLECT phase, any method that is collected must be added to the acfg->methods array as it is used by collect_methods and compile_method, which ensure generic instances. However, in the previous PR, this path was accidentally skipped because collect_dedup_methods returned TRUE in DEDUP_COLLECT phase.

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Apr 19, 2023

Closing this PR. Will be introduced after the snap.

@build-analysis build-analysis bot mentioned this pull request Apr 20, 2023
Closed
@kotlarmilos kotlarmilos mentioned this pull request Apr 26, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek approved these changes

@SamMonoRT SamMonoRT SamMonoRT approved these changes

@vargaz vargaz Awaiting requested review from vargaz

Assignees

@kotlarmilos kotlarmilos

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[Perf] Linux/x64: 861 Regressions on 4/17/2023 1:30:24 AM

3 participants

@kotlarmilos @lambdageek @SamMonoRT