Skip to content

Sync shared code from aspnetcore #85149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Sync shared code from aspnetcore #85149

merged 1 commit into from
Apr 21, 2023

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 21, 2023

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

@ghost
Copy link

ghost commented Apr 21, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@JamesNK
Copy link
Member

JamesNK commented Apr 21, 2023

@amcasey FYI, changes to shared source in aspnetcore needs to be mirrored here. It's easy with https://github.com/dotnet/runtime/actions/workflows/aspnetcore-sync.yml

@JamesNK JamesNK mentioned this pull request Apr 21, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 21, 2023
Closed
@Tratcher Tratcher merged commit 9ea909a into main Apr 21, 2023
@Tratcher Tratcher deleted the github-action/sync-aspnetcore-1682065319 branch April 21, 2023 15:17
@amcasey
Copy link
Member

amcasey commented Apr 21, 2023

@JamesNK Does that GH action need to be run manually? I was expecting it to happen automatically. In any case, sorry for the inconvenience.

@Tratcher
Copy link
Member

Tratcher commented Apr 21, 2023

Syncing from runtime to aspnetcore is automatic because we assume most updates happen in runtime. Syncing from aspnetcore to runtime is manual for when we update aspnetcore first. The actions only compare the diff, they don't know which version is 'right'.

@amcasey
Copy link
Member

amcasey commented Apr 21, 2023

Syncing from runtime to aspnetcore is automatic because we assume most updates happen in runtime. Syncing from aspnetcore to runtime is manual for when we update aspnetcore first. The actions only compare the diff, they don't know which version is 'right'.

Guess I get to make another doc update. 😆

amcasey added a commit to amcasey/runtime that referenced this pull request Apr 21, 2023
@amcasey
Shared Readme: expand the section on GH Actions
53c89e1 
...to clarify that dotnet->aspnetcore is automatic but aspnetcore->dotnet is manual.

Prompted by dotnet#85149
@amcasey amcasey mentioned this pull request Apr 21, 2023
Merged
amcasey added a commit that referenced this pull request Apr 22, 2023
@amcasey
Shared Readme: expand the section on GH Actions (#85173)
af07521 
...to clarify that dotnet->aspnetcore is automatic but aspnetcore->dotnet is manual.

Prompted by #85149
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2023
@karelz karelz added this to the 8.0.0 milestone May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamesNK JamesNK JamesNK approved these changes

@ManickaP ManickaP ManickaP approved these changes

Assignees

No one assigned

Labels

area-System.Net.Http

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

6 participants

@JamesNK @amcasey @Tratcher @ManickaP @karelz