JIT: Create side effect commas as TYP_VOID in block morph #85320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code could create IR shapes like
COMMA struct
...
ASG struct
dst
src
After liveness that would sometimes result in
COMMA struct
...
NOP void
which could confuse optimization phases when JitOptRepeat was enabled.
The more canonical shape for these side-effecting GT_COMMA nodes has
them TYP_VOID typed as shown by gtExtractSideEffList, so do the same in
block morph.
Fix dotnet#85037
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis code could create IR shapes like COMMA struct which could confuse optimization phases when JitOptRepeat was enabled. The more canonical shape for these side-effecting GT_COMMA nodes has them TYP_VOID typed as shown by gtExtractSideEffList, so do the same in block morph. Fix #85037 There are still other cases where we produce the non-canonical typed commas, e.g.
|
|
cc @dotnet/jit-contrib PTAL @EgorBo |
EgorBo
approved these changes
Apr 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code could create IR shapes like
After liveness that would sometimes result in
which could confuse optimization phases when JitOptRepeat was enabled.
The more canonical shape for these side-effecting GT_COMMA nodes has them TYP_VOID typed as shown by gtExtractSideEffList, so do the same in block morph.
Fix #85037
There are still other cases where we produce the non-canonical typed commas, e.g.
impAssignStruct. I started trying to fix it but it looks like it will take a larger clean up.