Enable more ILLink tests in NativeAOT #85651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e31ba1d.
Also fixes the infra to correctly process all inputs (including additional dependencies). Enables one more test and disables one which is not meant to work yet.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsProduct fixes:
Test fixes:
Enables several more data flow tests from linker for AOT as well.
|
Member
Author
|
This is ready for review - all CI failures are unrelated. |
sbomer
approved these changes
May 3, 2023
|
|
||
| foreach (var rootedAssembly in options.AdditionalRootAssemblies) { | ||
| // For compatibility with IL Linker, the parameter could be a file name or an assembly name. | ||
| // This is the logic IL Linker uses to decide how to interpret the string. Really. |
Member
There was a problem hiding this comment.
😢 Do our tests actually use the file path case? Wondering if we can just leave it out here.
Member
Author
There was a problem hiding this comment.
Good point - I'll remove that (I just blindly copied this from ilc)
| "<Module>.MainMethodWrapper()" | ||
| "<Module>.MainMethodWrapper()", | ||
|
|
||
| // Ignore compiler generated code which can't be reasonably matches to the source method |
Member
There was a problem hiding this comment.
Suggested change
| // Ignore compiler generated code which can't be reasonably matches to the source method | |
| // Ignore compiler generated code which can't be reasonably matched to the source method |
agocke
approved these changes
May 3, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product fixes:
Test fixes:
Enables several more data flow tests from linker for AOT as well.
Updates some bug links to point to runtime repo.