JIT: Refactor physical promotion in preparation of generalized assignment decomposition #85728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment decomposition This refactors the physical promotion to make the generalized assignment decomposition PR more manageable to review. * Pull Replacement and ReplaceVisitor into the header * Introduce promotiondecomposition.cpp that deals with handling assignments * Rename StatementList -> DecompositionStatementList and unnest it Also adds some more JITDUMPs when picking promotions, but otherwise should not affect behavior.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis refactors physical promotion to make the generalized assignment decomposition PR more manageable to review.
Also adds some more
|
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS. Should be no difference in behavior. |
EgorBo
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors physical promotion to make the generalized assignment decomposition PR more manageable to review.
ReplacementandReplaceVisitorinto the headerpromotiondecomposition.cppthat deals with handling assignments, and move relevant code frompromotion.cppto this fileStatementList->DecompositionStatementListand unnest itReplacement::Name->Replacement::Descriptionwhich is more fittingAlso adds some more
JITDUMPs when picking promotions, but otherwise should not affect behavior.