JIT: prepare for instrumentation before incorporating profile counts #85805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the spanning tree we generate may be biased by the profile data and not match the spanning tree we generated in Tier0. Fixes dotnet#85799.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsOtherwise the spanning tree we generate may be biased by the profile data and not match the spanning tree we generated in Tier0. Fixes #85799.
|
|
@EgorBo PTAL Some diffs mainly in instrumentation patterns in Tier1 instr code. Also likely diffs in optimized methods where schemas should now match, but SPMI will probably fail to replay those. |
|
We should assert that we never have a schema mismatch with Dynamic PGO. Will try that subsequently. |
EgorBo
approved these changes
May 5, 2023
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this pull request
May 8, 2023
When the profile data comes from dynamic PGO, the spanning tree encoded in the schema produced by an earlier tier should exactly match the spanning tree for the current jit attempt, since the JIT and method IL are identical. (This is not the case for static PGO; that schema may have come from a different JIT and/or different version of IL). Note in release modes we won't assert; instead, we will silently throw the PGO data away. Follow-on change to dotnet#85805 to catch more issues like dotnet#85799.
AndyAyersMS
added a commit
that referenced
this pull request
May 8, 2023
When the profile data comes from dynamic PGO, the spanning tree encoded in the schema produced by an earlier tier should exactly match the spanning tree for the current jit attempt, since the JIT and method IL are identical. (This is not the case for static PGO; that schema may have come from a different JIT and/or different version of IL). Note in release modes we won't assert; instead, we will silently throw the PGO data away. Follow-on change to #85805 to catch more issues like #85799.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the spanning tree we generate may be biased by the profile data and not match the spanning tree we generated in Tier0.
Fixes #85799.