Skip to content

[mono][aot] Generate 'native-indirect' wrappers in full-aot mode. #85923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

[mono][aot] Generate 'native-indirect' wrappers in full-aot mode. #85923

merged 1 commit into from
May 9, 2023

Conversation

@vargaz
Copy link
Contributor

@vargaz vargaz commented May 8, 2023

Fixes #80853.

@ghost ghost added the area-Codegen-AOT-mono label May 8, 2023
@vargaz vargaz removed the request for review from lambdageek May 8, 2023 16:29
@ghost ghost assigned vargaz May 8, 2023
@vargaz vargaz requested a review from lambdageek May 8, 2023 16:29
@vargaz vargaz force-pushed the native-indirect branch from a4f76c9 to 57d3f7f Compare May 8, 2023 17:22
@vargaz vargaz requested a review from thaystg as a code owner May 8, 2023 17:22
@Boxter187
Copy link

Fixes #80853.

Can't sing for my Firefox account with this hash tag number what do you think to get it right??

@vargaz vargaz force-pushed the native-indirect branch from 57d3f7f to 7cedcd9 Compare May 8, 2023 17:37
@vargaz
Copy link
Contributor Author

vargaz commented May 8, 2023

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SamMonoRT
SamMonoRT reviewed May 8, 2023
View reviewed changes
@SamMonoRT
Copy link
Member

we should also run extraplatforms once initial validation is completed

cc @jandupej @kotlarmilos - please review the changes

@vargaz vargaz force-pushed the native-indirect branch from 7cedcd9 to 2ae8bb9 Compare May 8, 2023 19:53
@vargaz
Copy link
Contributor Author

vargaz commented May 8, 2023

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz added the NO-REVIEW Experimental/testing PR, do NOT review it label May 8, 2023
This was referenced May 8, 2023
Closed
Closed
@vargaz vargaz force-pushed the native-indirect branch from 2ae8bb9 to ebe1425 Compare May 8, 2023 22:53
@vargaz vargaz removed the NO-REVIEW Experimental/testing PR, do NOT review it label May 8, 2023
This was referenced May 8, 2023
Closed
Closed
kotlarmilos
kotlarmilos approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jandupej
jandupej approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@jandupej jandupej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM.

@vargaz
Copy link
Contributor Author

vargaz commented May 9, 2023

Wasm failures are unrelated.

@vargaz vargaz merged commit 209d681 into dotnet:main May 9, 2023
@vargaz vargaz deleted the native-indirect branch May 9, 2023 21:30
@radical radical mentioned this pull request May 10, 2023
Closed
@steveisok steveisok mentioned this pull request May 18, 2023
Closed
@SamMonoRT
Copy link
Member

@kotlarmilos @vargaz - we should start the backport to 7 for this issue.

@kotlarmilos
Copy link
Member

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5129756689

@github-actions github-actions bot mentioned this pull request May 31, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SamMonoRT SamMonoRT SamMonoRT left review comments

@kotlarmilos kotlarmilos kotlarmilos approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

+1 more reviewer

@jandupej jandupej jandupej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vargaz vargaz

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Starting App on iOS fails with System.ExecutingEngineException

5 participants

@vargaz @Boxter187 @SamMonoRT @kotlarmilos @jandupej