Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 9, 2023

Backport of #85022 to release/8.0-preview4

/cc @lewing @radical

Customer Impact

Fixes the wasi build when installed in the system wide location

Testing

Patch has been in main for two weeks with no issues

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@github-actions github-actions bot requested a review from marek-safar as a code owner May 9, 2023 17:36
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 9, 2023
@lewing lewing added the Servicing-consider Issue for next servicing release review label May 9, 2023
@lewing
Copy link
Member

lewing commented May 9, 2023

If this is approved there is no need to wait for CI, the change here only impacts the wasi legs which are broken without this

@lewing lewing added os-wasi Related to WASI variant of arch-wasm arch-wasm WebAssembly architecture labels May 9, 2023
@ghost
Copy link

ghost commented May 9, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #85022 to release/8.0-preview4

/cc @lewing @radical

Customer Impact

Fixes the wasi build when installed in the system wide location

Testing

Patch has been in main for two weeks with no issues

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, os-wasi, needs-area-label

Milestone: -

@lewing lewing requested a review from carlossanlop May 9, 2023 18:12
@lewing lewing added the Servicing-approved Approved for servicing release label May 9, 2023
@lewing lewing merged commit 84a3d0e into release/8.0-preview4 May 9, 2023
@lewing lewing deleted the backport/pr-85022-to-release/8.0-preview4 branch May 9, 2023 18:43
@lewing lewing requested a review from mmitche May 9, 2023 18:59
@lewing
Copy link
Member

lewing commented May 9, 2023

this was approved offline with @mmitche and @SteveMCarroll

@carlossanlop carlossanlop removed the Servicing-consider Issue for next servicing release review label May 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-wasi Related to WASI variant of arch-wasm Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants