Skip to content

Add ImmutableArray.Contains overload that accepts an IEqualityCompare… #86210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2023
Merged

Add ImmutableArray.Contains overload that accepts an IEqualityCompare… #86210

merged 1 commit into from
May 14, 2023

Conversation

@RaymondHuy
Copy link
Contributor

@RaymondHuy RaymondHuy commented May 13, 2023

Resolve #66758

@ghost
Copy link

ghost commented May 13, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 13, 2023
@ghost
Copy link

ghost commented May 13, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolve #66758

Author: RaymondHuy
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation
Milestone: -

@build-analysis build-analysis bot mentioned this pull request May 13, 2023
Closed
stephentoub
stephentoub approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit c7008d3 into dotnet:main May 14, 2023
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request May 15, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-System.Collections community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add ImmutableArray.Contains overload that accepts an IEqualityComparer<T>

2 participants

@RaymondHuy @stephentoub