Skip to content

Conversation

@cshung
Copy link
Contributor

@cshung cshung commented May 15, 2023

The UnregisterFrozenSegment private API call in the Frozen test case is causing repeated CI failures. I attempted to fix it multiple times, but there are still crashes.

We are unaware of anyone actually using it, so we decided this is a low priority and disabled testing it for now.

@cshung cshung marked this pull request as draft May 15, 2023 20:43
@ghost ghost added the area-GC-coreclr label May 15, 2023
@ghost ghost assigned cshung May 15, 2023
@ghost
Copy link

ghost commented May 15, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment to say "we are not aware of anyone calling this API so it's low priority to fix"

@cshung cshung marked this pull request as ready for review May 16, 2023 13:36
@cshung cshung merged commit f0de000 into dotnet:main May 16, 2023
@cshung cshung deleted the public/stop-testing-unregister branch May 16, 2023 19:20
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants