Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7 #86306

dviererbe · 2023-05-16T09:41:19Z

Description

Adds the Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7

library Microsoft.NETCore.Platforms
- added RIDs to runtime.compatibility.json
- added RIDs to runtime.json
- added Mantic Version Id to Ubuntu runtimeGroups.props
- incremented ServicingVersion in Microsoft.NETCore.Platforms.csproj

Customer Impact

Will be able to target their build specifically for Ubuntu 23.10 (Mantic Minotaur) or include Ubuntu 23.10 (Mantic Minotaur) platform-specific assets.

Regression

No.

Testing

From a clean copy of your branch, run build.sh libs -allconfigurations
Check in artifacts/bin/packages/Debug for the existence of Microsoft.NETCore.Platforms, with the appropriate package version.
- test -d artifacts/bin/Microsoft.NETCore.Platforms/ && echo "Ok"
- test -e artifacts/bin/Microsoft.NETCore.Platforms/Debug/net7.0/Microsoft.NETCore.Platforms.BuildTasks.dll && echo "Ok"

Try installing the built package in a test application, testing that your changes to the library are present & working as expected.

grep ubuntu.23.10 artifacts/bin/Microsoft.NETCore.Platforms/Debug/runtime.json.dgml shows

<Node Id="ubuntu.23.10" />
<Node Id="ubuntu.23.10-x64" />
<Node Id="ubuntu.23.10-x86" />
<Node Id="ubuntu.23.10-arm" />
<Node Id="ubuntu.23.10-arm64" />
<Link Source="ubuntu.23.10" Target="ubuntu" />
<Link Source="ubuntu.23.10-x64" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-x64" Target="ubuntu-x64" />
<Link Source="ubuntu.23.10-x86" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-x86" Target="ubuntu-x86" />
<Link Source="ubuntu.23.10-arm" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-arm" Target="ubuntu-arm" />
<Link Source="ubuntu.23.10-arm64" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-arm64" Target="ubuntu-arm64" />

Check if Microsoft.NETCore.Platforms Library functions are callable

export DOTNET_REPO=$PWD
mkdir ../TestApp
cd ../TestApp

cat <<'EOF' >TestApp.csproj
<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>net7.0</TargetFramework>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
    </PropertyGroup>
    <ItemGroup>
        <Reference Include="Microsoft.NETCore.Platforms.BuildTasks">
            <HintPath>$(DOTNET_REPO)/artifacts/bin/Microsoft.NETCore.Platforms/Debug/net7.0/Microsoft.NETCore.Platforms.BuildTasks.dll</HintPath>
        </Reference>
    </ItemGroup>
</Project>
EOF

cat <<EOF >Program.cs
using Microsoft.NETCore.Platforms.BuildTasks;

// Test that library functions can be called
var rid = RID.Parse("ubuntu.23.10-x64", noQualifier: true);
Console.WriteLine("Mantic Minotaur: " + rid.ToString());

Console.WriteLine("Ok");
EOF

dotnet run

As far as I can tell the change works as expected.

Note: Builds & local Tests pass in ppa:dviererbe/dotnet7-0-105-mantic-2 (link) with this patch applied.

Risk

As for every change an unintended regression could be introduced. The risk for this is minimal, as the PR into main (#84983) and a recent similar PR for Ubuntu 22.10 (Kinetic Kudu) for.NET 7 (#84984) and .NET 6 (#85912) passed

Package authoring signed off?

Adding the Ubuntu 23.10 (Mantic Minotaur) RIDs was also suggested by @wfurt (see: #84984 (comment))

* library Microsoft.NETCore.Platforms - added RIDs to runtime.compatibility.json - added RIDs to runtime.json - added Mantic Version Id to Ubuntu runtimeGroups.props - incremented ServicingVersion in Microsoft.NETCore.Platforms.csproj

ghost · 2023-05-16T09:41:31Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

main PR #85912

Description

Adds the Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7

library Microsoft.NETCore.Platforms
- added RIDs to runtime.compatibility.json
- added RIDs to runtime.json
- added Mantic Version Id to Ubuntu runtimeGroups.props
- incremented ServicingVersion in Microsoft.NETCore.Platforms.csproj

Customer Impact

Will be able to target their build specifically for Ubuntu 23.10 (Mantic Minotaur) or include Ubuntu 23.10 (Mantic Minotaur) platform-specific assets.

Regression

No.

Testing

From a clean copy of your branch, run build.sh libs -allconfigurations
Check in artifacts/bin/packages/Debug for the existence of Microsoft.NETCore.Platforms, with the appropriate package version.
- test -d artifacts/bin/Microsoft.NETCore.Platforms/ && echo "Ok"
- test -e artifacts/bin/Microsoft.NETCore.Platforms/Debug/net7.0/Microsoft.NETCore.Platforms.BuildTasks.dll && echo "Ok"

Try installing the built package in a test application, testing that your changes to the library are present & working as expected.

grep ubuntu.23.10 artifacts/bin/Microsoft.NETCore.Platforms/Debug/runtime.json.dgml shows

<Node Id="ubuntu.23.10" />
<Node Id="ubuntu.23.10-x64" />
<Node Id="ubuntu.23.10-x86" />
<Node Id="ubuntu.23.10-arm" />
<Node Id="ubuntu.23.10-arm64" />
<Link Source="ubuntu.23.10" Target="ubuntu" />
<Link Source="ubuntu.23.10-x64" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-x64" Target="ubuntu-x64" />
<Link Source="ubuntu.23.10-x86" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-x86" Target="ubuntu-x86" />
<Link Source="ubuntu.23.10-arm" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-arm" Target="ubuntu-arm" />
<Link Source="ubuntu.23.10-arm64" Target="ubuntu.23.10" />
<Link Source="ubuntu.23.10-arm64" Target="ubuntu-arm64" />

Check if Microsoft.NETCore.Platforms Library functions are callable

mkdir TestApp
cd TestApp

cat <<EOF >TestApp.csproj
<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>net7.0</TargetFramework>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
    </PropertyGroup>
    <ItemGroup>
        <Reference Include="Microsoft.NETCore.Platforms.BuildTasks">
            <HintPath>../artifacts/bin/Microsoft.NETCore.Platforms/Debug/net7.0/Microsoft.NETCore.Platforms.BuildTasks.dll</HintPath>
        </Reference>
    </ItemGroup>
</Project>
EOF

cat <<EOF >Program.cs
using Microsoft.NETCore.Platforms.BuildTasks;

// Test that library functions can be called
var rid = RID.Parse("ubuntu.23.10-x64", noQualifier: true);
Console.WriteLine("Mantic Minotaur: " + rid.ToString());

Console.WriteLine("Ok");
EOF

dotnet run

As far as I can tell the change works as expected.

Note: Builds & local Tests pass in ppa:dviererbe/dotnet7-0-105-mantic-2 (link) with this patch applied.

Risk

As for every change an unintended regression could be introduced. The risk for this is minimal, as the PR into main (#84983) and a recent similar PR for Ubuntu 22.10 (Kinetic Kudu) for.NET 7 (#84984) and .NET 6 (#85912) passed

Package authoring signed off?

Adding the Ubuntu 23.10 (Mantic Minotaur) RIDs was also suggested by @wfurt (see: #84984 (comment))

Author:	dviererbe
Assignees:	-
Labels:	`area-Infrastructure-libraries`, `community-contribution`
Milestone:	-

dviererbe · 2023-05-16T10:19:04Z

I do not see how the "Libraries Build windows allConfigurations x64 Debug" failures

Unable to find a stable package Microsoft.Extensions.Logging.Abstractions with version (>= 7.0.1)
Unable to find a stable package System.DirectoryServices.Protocols with version (>= 7.0.1)
Unable to find a stable package System.Management with version (>= 7.0.2)

should be caused by my change

carlossanlop

We need this in the June release so the servicing version number needs to only be bumped once (stay in 3).

carlossanlop · 2023-05-16T16:44:55Z

src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj

    <_generateRuntimeGraphTask>$([MSBuild]::NormalizePath('$(BaseOutputPath)', $(Configuration), '$(_generateRuntimeGraphTargetFramework)', '$(AssemblyName).dll'))</_generateRuntimeGraphTask>
    <!-- When building from source, ensure the RID we're building for is part of the RID graph -->
    <AdditionalRuntimeIdentifiers Condition="'$(DotNetBuildFromSource)' == 'true'">$(AdditionalRuntimeIdentifiers);$(OutputRID)</AdditionalRuntimeIdentifiers>
-    <ServicingVersion>3</ServicingVersion>


Needs to stay 3 if we are to insert this into the June release.

src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj

…e.Platforms.csproj

wfurt

LGTM

wfurt

LGTM

Add Ubuntu 23.10 (Mantic Minotaur) RIDs

9f5af4a

* library Microsoft.NETCore.Platforms - added RIDs to runtime.compatibility.json - added RIDs to runtime.json - added Mantic Version Id to Ubuntu runtimeGroups.props - incremented ServicingVersion in Microsoft.NETCore.Platforms.csproj

ghost added area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member labels May 16, 2023

carlossanlop suggested changes May 16, 2023

View reviewed changes

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 16, 2023

carlossanlop reviewed May 16, 2023

View reviewed changes

src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj Outdated Show resolved Hide resolved

Update src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCor…

36230ee

…e.Platforms.csproj

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label May 16, 2023

wfurt approved these changes May 16, 2023

View reviewed changes

carlossanlop approved these changes May 16, 2023

View reviewed changes

carlossanlop added the Servicing-approved Approved for servicing release label May 16, 2023

carlossanlop added this to the 7.0.7 milestone May 16, 2023

carlossanlop merged commit 92f8090 into dotnet:release/7.0-staging May 16, 2023

build-analysis bot mentioned this pull request May 16, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

radical mentioned this pull request Jun 15, 2023

[IGNORE][wasm] debugging 7.0 aot failures #87586

Closed

ghost locked as resolved and limited conversation to collaborators Jun 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7 #86306

Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7 #86306

Uh oh!

dviererbe commented May 16, 2023 •

edited

Loading

Uh oh!

ghost commented May 16, 2023

Description

Customer Impact

Regression

Testing

Risk

Package authoring signed off?

Uh oh!

dviererbe commented May 16, 2023

Uh oh!

carlossanlop left a comment

Uh oh!

carlossanlop May 16, 2023

Uh oh!

Uh oh!

wfurt left a comment

Uh oh!

wfurt left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7 #86306

Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7 #86306

Uh oh!

Conversation

dviererbe commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Customer Impact

Regression

Testing

Risk

Package authoring signed off?

Uh oh!

ghost commented May 16, 2023

Description

Customer Impact

Regression

Testing

Risk

Package authoring signed off?

Uh oh!

dviererbe commented May 16, 2023

Uh oh!

carlossanlop left a comment

Choose a reason for hiding this comment

Uh oh!

carlossanlop May 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dviererbe commented May 16, 2023 •

edited

Loading