Remove call to morph on hoisted trees #86450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unnecessary (this causes no diffs). And theoretically if it did cause diffs, the morphed tree would then not match the tree being hoisted, meaning CSE wouldn't "find" it and consider it a CSE.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIt is unnecessary (this causes no diffs). And theoretically if it did cause diffs, the morphed tree would then not match the tree being hoisted, meaning CSE wouldn't "find" it and consider it a CSE.
|
Contributor
Author
|
@AndyAyersMS PTAL |
AndyAyersMS
approved these changes
May 18, 2023
Contributor
Author
|
No diffs on win-x64, but a couple elsewhere where we get an additional CSE. TP is a nice (small) win. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unnecessary (this causes no diffs). And theoretically if it did cause diffs, the morphed tree would then not match the tree being hoisted, meaning CSE wouldn't "find" it and consider it a CSE.