Add DiagnosticOr<T> type for gracefully handling failures in incremental generator transformations
#86603
+205
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ratorStringMarshalling
…conditional access
…arshallingMatchBase
…arshallingMatchBase
…arshallingMatchBase
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsBuilds off of #86467, so wait until that is finished to review the diff. Adds the DiagnosticOr type that represents either the expected return value, or a diagnostic of why the transformation failed. This replaces the Tuple of (T?, Diagnostic?) that was previously used. Adds a few extension methods on IncrementalValuesProvider and IncrementalGeneratorInitializationContext to make reporting diagnostics and filtering out diagnostics from values.
|
...raries/System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/DiagnosticOr.cs
Show resolved
Hide resolved
...raries/System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/DiagnosticOr.cs
Outdated
Show resolved
Hide resolved
...raries/System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/DiagnosticOr.cs
Outdated
Show resolved
Hide resolved
...raries/System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/DiagnosticOr.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
May 24, 2023
Member
Author
|
Test failures are known |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #86467, so wait until that is finished to review the diff.
Adds the DiagnosticOr type that represents either the expected return value, or a diagnostic of why the transformation failed. This replaces the Tuple of (T?, Diagnostic?) that was previously used.
Adds a few extension methods on IncrementalValuesProvider and IncrementalGeneratorInitializationContext to make reporting diagnostics and filtering out diagnostics from values.