Skip to content

Conversation

@tmds
Copy link
Member

@tmds tmds commented May 24, 2023

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners community-contribution Indicates that the PR has been added by a community member labels May 24, 2023
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in eng/common come from dotnet/arcade. Can we update them there and consume the updates here?

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 24, 2023
@tmds
Copy link
Member Author

tmds commented May 24, 2023

The files in eng/common come from dotnet/arcade. Can we update them there and consume the updates here?

I will look into it.

Can we trigger the banana-leg on this PR to validate this fixes the issue?

@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label May 24, 2023
@ViktorHofer
Copy link
Member

Unfortunately there isn't a good way without a yml change. If you temporarily remove the following condition, the banana sourcebuild leg should run:

condition: eq(variables['isRollingBuild'], true)

@tmds tmds force-pushed the banana_pass_baseos branch from 5d53e28 to 359485c Compare May 24, 2023 14:02
@tmds
Copy link
Member Author

tmds commented May 24, 2023

@tmds
Copy link
Member Author

tmds commented May 24, 2023

The files in eng/common come from dotnet/arcade. Can we update them there and consume the updates here?

Created dotnet/arcade#13677.

@ViktorHofer ViktorHofer added the blocked Issue/PR is blocked on something - see comments label May 24, 2023
@ViktorHofer
Copy link
Member

Blocked on dotnet/arcade#13677 and #86494

@ViktorHofer ViktorHofer removed the blocked Issue/PR is blocked on something - see comments label May 31, 2023
@ViktorHofer ViktorHofer reopened this May 31, 2023
@ViktorHofer ViktorHofer merged commit 4ac21d7 into dotnet:main May 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failure in the "banana" rid leg on Centos Stream 8

3 participants