[release/8.0-preview5] Add Microsoft.Extensions.Diagnostics.* to Aspnet Transport package #86730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #86725 to release/8.0-preview5 /cc @wtgodbe Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
eerhardt
approved these changes
May 24, 2023
carlossanlop
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #86725 to release/8.0-preview5
/cc @wtgodbe
Customer Impact
This Microsoft.Extensions.Diagnostics.* assemblies were added as a packages in Preview5 but we didn't add them to the ASP.NET Shared framework. We need these in the shared framework so that ASP.NET can depend on it and use it. Without this change ASP.NET would be shipping a hack and we would miss out on feedback on the real feature.
Testing
This change is mechanical to add the reference assemblies to our transport pack. ASP.NET has tested consumption of the new libraries and they are working.
This issue was discovered during codeflow.
Risk
Low - this merely adds reference assemblies to the shared framework package.