[interp] Add MINT_STELEM_VT_NOREF #87161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
requested review from
BrzVlad,
kotlarmilos,
lewing,
pavelsavara and
vargaz
as code owners
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsBased on instrumentation 0.2% of all
|
|
Looks ok to me. |
BrzVlad
reviewed
Jun 6, 2023
lewing
approved these changes
Jul 7, 2023
BrzVlad
approved these changes
Jul 8, 2023
kg
added a commit
to kg/runtime
that referenced
this pull request
Jul 12, 2023
This reverts commit e05b3e7.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on instrumentation 0.2% of all
mono_gc_wbarrier_value_copy_internalcalls in a run of System.Runtime.Tests are fromMINT_STELEM_VT. I suspect adding this NOREF version of the opcode will improve performance for data structures that store structs in arrays but don't contain any references - for exampleList<ValueTuple<...>>orDictionary<int, int>- but it's hard to measure locally.