Remove a couple of asserts, which are no longer valid, from getMaxVectorTByteLength #87504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #87432. There are several scenarios where Vector may not be supported beyond simply the intrinsics being disabled. As such, the asserts should just be removed.8.
|
|
CC. @dotnet/jit-contrib, @BruceForstall This should unblock the asm diffs pipeline. |
TIHan
approved these changes
Jun 14, 2023
|
Thanks for this; sorry I dropped the ball on reviewing it quickly. |
|
No worries, looks like the job is running well and should complete here shortly |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #87432.
There are several scenarios where
Vector<T>may not be supported beyond simply the intrinsics being disabled. As such, the asserts should just be removed.