Allow unnecessary [In, Out] attributes on blittable arrays and report them as unnecessary #87774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsInstead of blocking unnecessary Depends on #87700
|
…essary but not invalid' to enable us in the future to report a non-fatal diagnostic.
jkoritzinsky
force-pushed
the
byval-marshal-unnecessary
branch
from
9d1f037 to
f0cb451
Compare
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
…assets. Use the inbox instead.
This was referenced Jun 24, 2023
AaronRobinsonMSFT
approved these changes
Jun 26, 2023
...m.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/MarshalAsAttributeParser.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Interop.SourceGeneration/Marshalling/AttributedMarshallingModelGeneratorFactory.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of blocking unnecessary
[In, Out]attributes on members where they aren't required to specify the behavior in that case, allow them and report a diagnostic that they're unnecessary. This diagnostic will fade-out the attributes and specify that they aren't required to get the expected behavior. We'll only do this on use cases where the attributes could be valid/required to get the desired behavior.Depends on #87700