Support relative path for ICU_DAT_FILE_PATH on iOS/tvOS/Catalyst #87813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We consider it relative to the app bundle root. Required for dotnet/macios#17877 and NativeAOT scenarios.
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsWe consider it relative to the app bundle root. Required for dotnet/macios#17877 and NativeAOT scenarios.
|
rolfbjarne
approved these changes
Jun 20, 2023
52 tasks
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos Issue DetailsWe consider it relative to the app bundle root. Required for dotnet/macios#17877 and NativeAOT scenarios.
|
steveisok
approved these changes
Jun 20, 2023
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Jun 20, 2023
We can fix this better once this fix reaches us:
dotnet/runtime#87813
because then we can set the ICU data file at build time (to a relative path).
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Jun 22, 2023
We can fix this better once this fix reaches us:
dotnet/runtime#87813
because then we can set the ICU data file at build time (to a relative path).
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We consider it relative to the app bundle root.
Required for dotnet/macios#17877 and NativeAOT scenarios.